Last fixes

mckinsey · Mar 7, 2025 · 7fc2246 · 7fc2246
1 parent 39be3a1
commit 7fc2246
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/vizro-core/src/vizro/models/_base.py b/vizro-core/src/vizro/models/_base.py
@@ -214,7 +214,7 @@ class VizroBaseModel(BaseModel):
         str,
         AfterValidator(set_id),
         Field(
-            default="",  # TODO[MS]: potentially change to None
+            default="",
             description="ID to identify model. Must be unique throughout the whole dashboard."
             "When no ID is chosen, ID will be automatically generated.",
             validate_default=True,

diff --git a/vizro-core/src/vizro/models/_dashboard.py b/vizro-core/src/vizro/models/_dashboard.py
@@ -44,7 +44,7 @@ def _all_hidden(components: list[Component]):
     return all(
         component is None
         or getattr(component, "hidden", False)
-        or "d-none" in getattr(component, "className", "d-inline")  # TODO: this may be important
+        or "d-none" in getattr(component, "className", "d-inline")
         for component in components
     )