Merge pull request #959 from mcneel/1.16

Fix on 'Delete Element' component.
mcneel · Jul 25, 2023 · 21d1490 · 21d1490
2 parents cc4dc62 + b2d3d5d
commit 21d1490
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/src/RhinoInside.Revit.GH/Components/Element/Delete.cs b/src/RhinoInside.Revit.GH/Components/Element/Delete.cs
@@ -136,7 +136,7 @@ int Delete
       var result = 0;
       if (elementIds.Count > 0)
       {
-        using (var updater = deleted is object && modified is object ? new Updater(document) : default)
+        using (var updater = modified is object ? new Updater(document) : default)
         {
           if (!document.CanDeleteElements(elementIds))
           {
@@ -154,32 +154,34 @@ int Delete
             {
               result = DeletedElementIds.Count;
 
-              if (updater?.DeletedElementIds is object)
+              var deletedElementIds = updater?.DeletedElementIds ?? DeletedElementIds;
+              if (deletedElementIds is object)
               {
-                deleted.AddRange
+                deleted?.AddRange
                 (
-                  updater.DeletedElementIds.Select(x => new Types.Element(document, x)),
-                  updater.DeletedElementIds.Count
+                  deletedElementIds.Select(x => new Types.Element(document, x)),
+                  deletedElementIds.Count
                 );
               }
             }
             else
             {
               result = -1;
 
-              if (updater?.DeletedElementIds is object)
+              var deletedElementIds = updater?.DeletedElementIds ?? DeletedElementIds;
+              if (deletedElementIds is object)
               {
-                deleted.AddRange
+                deleted?.AddRange
                 (
-                  updater.DeletedElementIds.Select(x => Types.Element.FromElementId(document, x)),
-                  updater.DeletedElementIds.Count
+                  deletedElementIds.Select(x => Types.Element.FromElementId(document, x)),
+                  deletedElementIds.Count
                 );
               }
             }
 
             if (updater?.ModifiedElementIds is object)
             {
-              modified.AddRange
+              modified?.AddRange
               (
                 updater.ModifiedElementIds.Select(x => Types.Element.FromElementId(document, x)),
                 updater.ModifiedElementIds.Count