Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update updateAction plugin #25

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from

Conversation

marcingy
Copy link

Update plugin so as matches new definition for action plugins.

@Berdir
Copy link
Member

Berdir commented Jan 13, 2015

Thanks, are we sure that this is really the right access check? Is there nothing that we should check. e.g. a permission? Like 'create url aliases' from path.module.

*/
public function access($object, AccountInterface $account = NULL, $return_as_object = FALSE) {
$result = AccessResult::allowed();
return $return_as_object ? $result : $result->isAllowed();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not checking any permission here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants