Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#51] Add permission to administer Redirect settings #85

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from

Conversation

juampynr
Copy link
Contributor

@juampynr juampynr commented Feb 6, 2016

For #51.

Based on #65.

@juampynr
Copy link
Contributor Author

@Berdir is there anything missing in this pull request that I should work on?

@Berdir
Copy link
Member

Berdir commented Feb 11, 2016

Usually, an administer permission can do everything. That's a pretty common pattern. I'm not sure I like changing that.

What if we turn it around and introduce something like a "manage redirects" permission and update the titles/descriptions so that it's clear that administer allows access to the settings and redirects, while the second permission only allows to manage redirects?

@juampynr
Copy link
Contributor Author

That makes sense to me. Updating pull request now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants