For final task pull requests.
- Create github account. Preferrably using email you used when registerer on this course
- Fork this repository. ('Fork' button at the top right of this repository page)
- Open the page of your new repository that was created when you forked this repo.
- Press button clone or download at the middle right of the page and CTRL-C the url.
- On your machine go to the directory you want.
- Depending on the OS you are working with, open GitBash(Windows)/Command Line or Terminal(Linux) there
- Use command
git clone <url_you_copied>
Congrats! You have successfully forked our repository.
setup.py
file for setuptools must be in the root offinal_task
folder. Usesetup.py
that is already there. (that means path to this file must end withfinal_task/setup.py
)- Entry point to your application, aka its main module must be named as
rss_reader.py
. Userss_reader.py
that is already inrss_reader
folder. - You should describe how does your project work, how to launch it and etc in README.md in the
final_task/README.md
file. - If you used any non-standart libraries they must be listed in
rss_reader/requirements.txt
file. - All unit test files should be in separate folder called
tests
.
- When creating pull request make sure that
target branch
ismaster
on OUR repo, not yours. - Pull request name MUST be in format:
YourFirstName_YourLastName_EmailYouUsedWhileRegisteringOnThisCourse
- Pull request which have any other name format, or invalid e-mail will be ignored completely until you fix it. So make sure you specified correct e-mail.
- In pull request description specify your current iteration. You also can add there any other info you want us to know before we start code review.
- Pull request must NOT contain any .pyc files, any virtual environment files/folders, any IDE technical files.