Rohanbh #2
Open
Rohanbh #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hareshkh
reviewed
Feb 8, 2017
| android:scaleType="centerCrop" | ||
| android:id="@+id/movie_image" /> | ||
|
|
||
| <LinearLayout |
There was a problem hiding this comment.
Linear Layout is not required here. All the views can be directly a child of the Relative Layout.
hareshkh
reviewed
Feb 8, 2017
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="Good luck with your assignments" /> | ||
| <android.support.v7.widget.RecyclerView |
There was a problem hiding this comment.
RecyclerView is an extension of a view group, and can be used as root layout in absence of other views, which is the case here.
hareshkh
reviewed
Feb 8, 2017
| MoviesAdapter adapter=new MoviesAdapter(myMovies,this); | ||
| movieList.setAdapter(adapter); | ||
| movieList.setLayoutManager(new LinearLayoutManager(this)); | ||
| movieList.setHasFixedSize(true); |
There was a problem hiding this comment.
Use this with caution. Refer here .
|
@RohanBh Please work on review comments, resolve merge conflicts (as I merged Dakshit's PR with master first, the updated master has conflicts in three files. If there is nothing to work on review comments, just respond something. End this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment #1