-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rohanbh #2
base: master
Are you sure you want to change the base?
Conversation
android:scaleType="centerCrop" | ||
android:id="@+id/movie_image" /> | ||
|
||
<LinearLayout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linear Layout is not required here. All the views can be directly a child of the Relative Layout.
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:text="Good luck with your assignments" /> | ||
<android.support.v7.widget.RecyclerView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RecyclerView is an extension of a view group, and can be used as root layout in absence of other views, which is the case here.
MoviesAdapter adapter=new MoviesAdapter(myMovies,this); | ||
movieList.setAdapter(adapter); | ||
movieList.setLayoutManager(new LinearLayoutManager(this)); | ||
movieList.setHasFixedSize(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use this with caution. Refer here .
@RohanBh Please work on review comments, resolve merge conflicts (as I merged Dakshit's PR with master first, the updated master has conflicts in three files. If there is nothing to work on review comments, just respond something. End this today. |
Assignment #1