style: run prettier on learn #20538
Merged
style: run prettier on learn #20538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
requested review from
teoli2003,
schalkneethling and
estelle
and removed request for
a team
This comment was marked as resolved.
This comment was marked as resolved.
|
Prettier is removing the escaping for tags inside of alt text for images causing Markdownlint issues. I think prettier is correct, so I've flipped this to draft and raised DavidAnson/markdownlint#579 |
|
I re-escaped the tags to make Markdownlint happy. There were one or 2 other minor prettier ones I ran into later that might need workarounds, so this doesn't need to wait for an upstream fix |
teoli2003
suggested changes
Sep 11, 2022
files/en-us/learn/common_questions/what_are_browser_developer_tools/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn/common_questions/what_are_browser_developer_tools/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn/html/introduction_to_html/getting_started/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn/html/introduction_to_html/the_head_metadata_in_html/index.md
Outdated
Show resolved
Hide resolved
…in_html/index.md Co-authored-by: Jean-Yves Perrier <[email protected]>
…tools/index.md Co-authored-by: Jean-Yves Perrier <[email protected]>
…tools/index.md Co-authored-by: Jean-Yves Perrier <[email protected]>
teoli2003
approved these changes
Sep 11, 2022
himanshugarg
pushed a commit
to himanshugarg/content
that referenced
this pull request
Sep 27, 2022
* style: run prettier on learn * fix: re-escape tags in alt for Markdownlint * Update files/en-us/learn/html/introduction_to_html/the_head_metadata_in_html/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/learn/common_questions/what_are_browser_developer_tools/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/learn/common_questions/what_are_browser_developer_tools/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * fix: replace HTML only alt text * Remove extra trailing spaces Co-authored-by: Jean-Yves Perrier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was run with embeddedLanguageFormatting off to reduce noise