CSS module: flexible box layout #34152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:CSS
|
Preview URLs (comment last updated: 2024-06-17 09:48:46) |
chrisdavidmills
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
@estelle looking good! Only a couple of very small nits, so approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS module landing page refresh to new template.
there are some properties that are listed in both the reference under 'properties' and under related content under box alignment. This is intentional as they are definitely flex properties, but the box alignment definitions supersede the flexbox. Didn't want to remove them from either list.
addressed as part of CSS baseline / interop openwebdocs/project#189 - subcomponent openwebdocs/project#202