-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(css): add missing css color-mix()
function
#857
Conversation
full test log in chromium:
Note Though the |
Do you want to have a look at the merge conflicts? It's probably quicker for you on this one :) |
"syntax": "in [ <rectangular-color-space> | <polar-color-space> <hue-interpolation-method>? ]" | ||
"syntax": "in [ <rectangular-color-space> | <polar-color-space> <hue-interpolation-method>? | <custom-color-space> ]" | ||
}, | ||
"color-mix()": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose in duplicating the color-mix()
entry here, also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is simply the current behavior, see #811, to have css functions both in syntaxes.json and functions.json
change it may bring break change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is again another case for mirroring members
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks correct, one clarifying question before we merge
Description
the css
color-mix()
function has been supported in all major platform for more than one year per bcdMotivation
Additional details
https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/color-mix
https://drafts.csswg.org/css-color-5/#funcdef-color-mix
Related issues and pull requests
report in csstree/validator#29