Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(css): Remove CSS Miscellaneous group & Rename CSS Variables group #882

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 5, 2025 08:33
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 5, 2025 08:33
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team January 5, 2025 08:33
@bsmth
Copy link
Member

bsmth commented Jan 15, 2025

I guess "Variables" is "CSS Custom Properties for Cascading Variables" per the module name, but I'm not sure how strict this needs to be.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for Variables comment, but +1 either way

@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Jan 15, 2025

seems mdn web docs also use "CSS Custom Properties for Cascading Variables"

see https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_cascading_variables

agree it is better to use "CSS Custom Properties for Cascading Variables"

@skyclouds2001 skyclouds2001 changed the title chore(css): remove CSS Miscellaneous group chore(css): Remove CSS Miscellaneous group & Rename CSS Variables group Jan 15, 2025
@skyclouds2001 skyclouds2001 requested a review from bsmth January 15, 2025 17:48
@bsmth bsmth merged commit 5edb039 into mdn:main Jan 16, 2025
3 checks passed
@skyclouds2001 skyclouds2001 deleted the CSS-Miscellaneous branch January 16, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants