Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(idle): support comments on staling or closing issue/pr #75

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Aug 14, 2022

Fixes: #56

If those message leave as empty, the comment will not be added.

See: https://github.com/actions/stale#stale-issue-message

@yin1999 yin1999 marked this pull request as ready for review August 14, 2022 08:27
@bsmth
Copy link
Member

bsmth commented Jun 30, 2023

There's another one open in #123 - should we wait for that to land first?

@yin1999
Copy link
Member Author

yin1999 commented Jun 30, 2023

There's another one open in #123 - should we wait for that to land first?

Sure, let's wait until #123 is landed :)

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but found a typo and suggested some less verbose descriptions.

.github/workflows/idle.yml Outdated Show resolved Hide resolved
.github/workflows/idle.yml Outdated Show resolved Hide resolved
.github/workflows/idle.yml Outdated Show resolved Hide resolved
.github/workflows/idle.yml Outdated Show resolved Hide resolved
.github/workflows/idle.yml Outdated Show resolved Hide resolved
.github/workflows/idle.yml Outdated Show resolved Hide resolved
@yin1999 yin1999 requested a review from caugner October 12, 2023 11:49
@caugner caugner changed the title feat: support add a comment on staling or closing issue/pr feat(idle): support comments on staling or closing issue/pr Oct 12, 2023
@caugner caugner merged commit 5f5c31e into mdn:main Oct 12, 2023
@yin1999 yin1999 deleted the patch-1 branch October 12, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow idle workflow to add a comment
4 participants