Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(bcd): prefix titles with browser name (and version) #12303

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jazzygasper
Copy link
Contributor

Summary

Fixes #10911

Problem

When looking at the compatibility table, especially for pages with long lists, you can't see the browser name when you scroll past the table header.

Solution

Added the browser name and version number to the tooltip in each cell so it says "Full support\nSafari 14.1", instead of just "Full support".


Screenshots

Before

Screenshot 2024-12-14 at 15 31 45

After

Screenshot 2024-12-14 at 15 32 49

How did you test this change?

Checked a page with a long compatibility list eg. http://localhost:3000/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#browser_compatibility. Hover over tick to check the browser name and version.

@jazzygasper jazzygasper requested a review from a team as a code owner December 14, 2024 23:59
@github-actions github-actions bot added the idle label Jan 17, 2025
@caugner caugner changed the title feat(compatibility-table): add browser name to compatibility table tooltip enhance(bcd): prefix titles with browser name (and version) Jan 27, 2025
@caugner
Copy link
Contributor

caugner commented Jan 27, 2025

@jazzygasper Thanks, I pushed some changes to align the changes. Let me know what you think:

  1. image
  2. image
  3. image

@github-actions github-actions bot removed the idle label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change alt/tooltips to include the browser name due to long lists
2 participants