Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a potential issues for all-zero dF seeds #667

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Fixed a potential issues for all-zero dF seeds #667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8659ca5
Fixed a potential issue for zero fBar.
friedenhe Jul 29, 2024
067be92
Small change to the dF structure.
friedenhe Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions dafoam/mphys/mphys_dafoam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ def apply_linear(self, inputs, outputs, d_inputs, d_outputs, d_residuals, mode):
d_inputs[inputName] += ACTDBarSub
else:
d_inputs[inputName] += ACTDBar

# compute [dRdHSC]^T*Psi using reverse mode AD
elif self.dvType[inputName] == "HSC":
prodVec = PETSc.Vec().create(self.comm)
Expand Down Expand Up @@ -1351,6 +1351,18 @@ def compute(self, inputs, outputs):
# compute the partial derivatives of functions
def compute_jacvec_product(self, inputs, d_inputs, d_outputs, mode):

# we first check if all the seeds in d_outputs are zeros. If yes, we return without calculation anything
n_non_zero_seeds = 0
for func_name in d_outputs:
if d_outputs[func_name] != 0.0:
n_non_zero_seeds += 1
if n_non_zero_seeds == 0:
return
elif n_non_zero_seeds > 1:
if self.comm.rank == 0:
print("************* Warning *************")
print("More than one non-zero seed found! ", d_outputs)

DASolver = self.DASolver

# set the runStatus, this is useful when the actuator term is activated
Expand Down Expand Up @@ -1381,7 +1393,8 @@ def compute_jacvec_product(self, inputs, d_inputs, d_outputs, mode):
funcsBar = {}

# assign value to funcsBar. NOTE: we only assign seed if d_outputs has
# non-zero values!
# non-zero values! We assume OM will pass only one non-zero seed here
# therefore, funcsBar should have only one key
if self.funcs is None:
raise AnalysisError("functions not set! Forgot to call mphys_add_funcs?")
else:
Expand All @@ -1394,7 +1407,7 @@ def compute_jacvec_product(self, inputs, d_inputs, d_outputs, mode):

if self.comm.rank == 0:
print("Computing partials for ", list(funcsBar.keys()))

# update the obj func name for solve_linear later
DASolver.setOption("solveLinearObjFuncName", list(funcsBar.keys())[0])
DASolver.updateDAOption()
Expand Down Expand Up @@ -1478,7 +1491,7 @@ def compute_jacvec_product(self, inputs, d_inputs, d_outputs, mode):
d_inputs[inputName] += ACTDBarSub * fBar
else:
d_inputs[inputName] += ACTDBar * fBar

# compute dFdHSC
elif self.dvType[inputName] == "HSC":
dFdHSC = PETSc.Vec().create(self.comm)
Expand Down
Loading