Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky tests #342

Merged
merged 3 commits into from
May 5, 2023
Merged

Remove flaky tests #342

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdc8c3a
remove flaky timing-based test
ewu63 May 2, 2023
30b6188
skip multiobjective NSGA2 tests
ewu63 May 3, 2023
ca90856
skip only the n_obj=2 test
ewu63 May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/test_nsga2_multi_objective.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from testing_utils import OptTest


@unittest.skip("skip flaky NSGA2 tests")
ewu63 marked this conversation as resolved.
Show resolved Hide resolved
class TestNSGA2(OptTest):
name = "quadratic"
optName = "NSGA2"
Expand Down
3 changes: 0 additions & 3 deletions tests/testing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,6 @@ def check_hist_file(self, tol):
times = hist.getValues(names="time", major=False)["time"]
# the times should be monotonically increasing
self.assertTrue(np.all(np.diff(times) > 0))
# the final time should be close to the metadata time
# we only specify a relatively loose atol because of variations in overhead cost between machines
assert_allclose(times[-1], metadata["optTime"], atol=1.0)

# this check is only used for optimizers that guarantee '0' and 'last' contain funcs
if self.optName in ["SNOPT", "PSQP"]:
Expand Down