Hr support #21
Closed
Hr support #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: index.html
|
This looks good! There's some git funkiness going on here, do you mind rebasing and squashing the relevant commits? The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows inserting hr (#19) by pressing enter when the previous paragraph is empty. In that case the previous paragraph is replaced by the hr. I loosely tested it in the latests chrome, firefox & IE and it works fine. The native deletion of a hr however varies from browser to browser, as mentioned in #20.
Aside from that the patch refactors some not-so-minor things:
triggerNodeAnalysisfunction. I think it will become usefull when we address Backspace bugs #20 as welltriggerTextParsehad some repetition withtriggerNodeAnalysisso I moved the common code inside an anonymous function called uponkeyup. This function does the common checkings and then calls the 2 others.hasParentWithTag. It now returns the first parent element that matches the given type instead of just true. It still works as a test function as previously but is also used in 3 places to grab a parent node.