fix(backend): svg layout attachments are not visible sometimes #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- read each blob's filename with extension from the event batch instead of the multipart request's form field headers - refactor attachment upload to build object key from a reliable source of filename - add more code documentation comments fixes #1736 Signed-off-by: detj <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anupcowkur
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where for some cases attachments like SVG layout snapshots would not render because of unexpected mime types (
application/octet-stream) inference. Attachment mime types would now be inferred from a more reliable source of information i.e. from the event batch itself rather than reading from the multipart request's form field headers.Tasks
See also