Truncate titles and descriptions when they exceed limits #559
Conversation
| @@ -1,13 +1,13 @@ | |||
| {% extends "base.html" %} | |||
| {% load static %} | |||
|
|
|||
| {% block headtitle %}{{media_object.title}} - {{PORTAL_NAME}}{% endblock headtitle %} | |||
| {% block headtitle %}{{media_object.title|add:" - "|add:PORTAL_NAME|truncatechars:64}}{% endblock headtitle %} | |||
There was a problem hiding this comment.
I think
{{media_object.title|truncatechars:5}} - {{PORTAL_NAME}} is what you want here, if you want to truncate the title and keep the portal name at the end
There was a problem hiding this comment.
In this case, I figured it was more important to have the media title in there than to always have the portal name in there, which is why I truncated the concatenation instead.
|
This is unrelated with the scope of this PR, however if you have the capacity to add it it would be great to wrap the description below the media (with a show more option) - since now it will display the whole description |
|
Fair enough. I'll see what I can do. |
I split this off into its own issue (#660) so I can remember to work on it. |
Description
Users on an instance I'm running like to use really long titles and descriptions. Per:
https://www.w3.org/Provider/Style/TITLE.html#:~:text=The%20title%20should%20ideally%20be,there%20is%20only%20limited%20room.
...titles should only be 64 characters long, and meta descriptions should usually be limited to 160 characters. This change truncates both if they exceed limits to keep things in compliance.
Steps
Pre-deploy
Post-deploy