Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set executable permission for shell scripts in dockerfile #572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KnotzerIO
Copy link

had this error:

docker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process

i added a run command to set the. executable permission on all .sh files within the app directory

fix error:
docker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process
Copy link

what-the-diff bot commented Jul 19, 2024

PR Summary

  • Improved Security for Shell Scripts
    The change greatly enhances the security of the application by managing the permissions of all shell scripts in the /app directory. As a result, it's now harder for unauthorized scripts to run, thereby reducing potential vulnerabilities.

@leonardehrenfried
Copy link
Collaborator

Once more, these AI-generated summaries are just really great!

Thanks for this PR though, @kno20205. However, shouldn't the permissions already be present because they are there in source files?

@KnotzerIO
Copy link
Author

I also thought so, but when I built the image locally and tried to run the container, I got a permission error. I have to mention that i use WSL and It might be just a workaround for a problem caused by Windows and WSL. It’s up to you whether to merge it, but if it could fix a potential error, why not add it? It’s better to include it than to miss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants