Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENABLE_WARMUP parameter #595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lorisleitner
Copy link

I added the parameter ENABLE_WARMUP to the start.sh script.

This new parameter allows skipping the database warmup routine after the container restarts.
Useful for answering requests immediately after the container starts.

Default value is true for backwards compatibility.

Copy link

what-the-diff bot commented Dec 24, 2024

PR Summary

  • Updated README.md document
    The README.md file now includes additional details about a new environment variable called ENABLE_WARMUP. This variable is used to manage the system's database warmup behavior and is by default set to 'true.'

  • Improved example.md document
    The example.md document has a new entry referring to the ENABLE_WARMUP variable. This entry offers direction to users, informing them that the variable can be assigned either a 'true' or 'false' value based on their preferences.

  • Restructured start.sh script

    • A new decision-making logic segment has been implemented. This routine checks the status of the ENABLE_WARMUP variable. If the variable is either unassigned or set to 'true,' a database warmup operation is initiated. If it is set to 'false,' the operation is skipped.
    • There has been an adjustment in the request time out and query settings, dependent on whether a warmup operation is carried out.

@leonardehrenfried
Copy link
Collaborator

leonardehrenfried commented Jan 3, 2025

Looks good but would you be able to add a test for this?

It's fine to disable it for 4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants