New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

May be bugs and disagreements between java and javascript implementation #9

Open

alxndrsn opened this issue Jan 10, 2019 · 0 comments

alxndrsn commented Jan 10, 2019

Test data starts at 2000 BS: https://github.com/medic/bikram-sambat/blob/master/test-data/daysInMonth.json
javascript implementation starts at 2007 BS: https://github.com/medic/bikram-sambat/blob/master/js/src/index.js#L7
3rd party implementation suggests that our days-in-month for year 2000 BS are incorrect: https://github.com/medic/bikram-sambat/blob/master/test-data/daysInMonth.json#L2 vs https://github.com/bahadurbaniya/Date-Converter-Bikram-Sambat-to-English-Date/blob/master/src/main/java/np/com/converter/date/nepali/Lookup.java#L233, even though this implementation seems to agree with ours for dates output

Steps forward:

write new level of testing which tests the output of our javascript and java implementations against each other
write new level of testing which tests the output of our java or javascript against implementation at https://github.com/bahadurbaniya/Date-Converter-Bikram-Sambat-to-English-Date

alxndrsn mentioned this issue

Support more dates (eg. <1950) #8

Closed

alxndrsn pushed a commit that referenced this issue


          Add integration tests to compare js and java implementations

133ad4c

Issue #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment