feat(flavours): add chv-neo flavour #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmwakanema
commented
Dec 14, 2023
danielmwakanema
commented
- The Kenya electronic Community Health Information System (eCHIS) is a standardized community health digital tool developed to improve community health service delivery and supply chain, reporting and performance management for better health outcomes at level one.
- CHV-NEO is an eCHIS instance/fork that includes pilot testing of patient to CHP SMS communication
jkuester
requested changes
Dec 14, 2023
| @@ -31,7 +31,7 @@ jobs: | |||
| - name: Set up Ruby | |||
| uses: ruby/setup-ruby@v1 | |||
| with: | |||
| ruby-version: 2.7 | |||
| ruby-version: 2.6 | |||
There was a problem hiding this comment.
Was this change intentional? I think we bumped this to 2.7 recently to address: #340
| @@ -222,39 +222,6 @@ jobs: | |||
| with: | |||
| lane: build | |||
| options: '{ "flavor": "itech_malawi" }' | |||
|
|
|||
| - name: Unpack secrets cares_malawi_kch | |||
There was a problem hiding this comment.
Did the jobs for cares_malawi_kch, cares_malawi_mpc, and moh_togo_uat get removed from there on purpose? If so, should we completely remove those brands from the repo?
| @@ -361,16 +361,6 @@ android { | |||
| applicationId = 'org.medicmobile.webapp.mobile.itech_malawi' | |||
| } | |||
|
|
|||
| cares_malawi_kch { | |||
There was a problem hiding this comment.
Same here. Was cares_malawi_kch, cares_malawi_mpc, and moh_togo_uat supposed to be removed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.