fix(#635): update upload-artifact GH action to version 4 (#636)

* fix(#635): update upload-artifact GH action to version 4 * fix e2e tests --------- Co-authored-by: m5r <[email protected]>
medic · Oct 9, 2024 · bafd6e3 · bafd6e3
1 parent 8e61099
commit bafd6e3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -25,7 +25,7 @@ jobs:
     - name: npm ci and test
       run: npm ci && npm test
     - name: Archive Results
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: Coverage Report ${{ matrix.node-version }}
         path: |

diff --git a/test/e2e/edit-app-settings.spec.js b/test/e2e/edit-app-settings.spec.js
@@ -12,6 +12,7 @@ const {
 
 describe('edit-app-settings', () => {
   const projectName = DEFAULT_PROJECT_NAME;
+  const findLanguage = (settingsLanguages, locale) => settingsLanguages.find(language => language.locale === locale);
 
   before(async () => {
     await initProject(projectName);
@@ -24,7 +25,8 @@ describe('edit-app-settings', () => {
   it('disables a language, recompile, and push app settings', async () => {
     const url = await getProjectUrl(projectName);
     const baseSettings = await request.get({ url: `${url}/api/v1/settings`, json: true });
-    baseSettings.languages.forEach(language => expect(language.enabled).to.be.true);
+    expect(findLanguage(baseSettings.languages, 'en').enabled).to.be.true;
+    expect(findLanguage(baseSettings.languages, 'fr').enabled).to.be.true;
     expect(baseSettings.locale).to.equal('en');
     expect(baseSettings.locale_outgoing).to.equal('en');