-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(#9443): offline user e2e test coverage for tasks #9498
chore(#9443): offline user e2e test coverage for tasks #9498
Conversation
@tatilepizs @lorerod @kapelo kindly have a look when you have some time |
@tatilepizs @lorerod @kapelo gentle reminder to kindly have a look at this |
Thank you for the heads up @ralfudx, I have been busy with other things that I have in my queue; I will review it as soon as I can, no later than the end of the week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these tests @ralfudx.
I left some suggestions and questions 😊
@tatilepizs I have made the requested changes and also added comments to the questions asked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing this @tatilepizs I have checked the new comments and follow-ups and made the requested modifications - Kindly have a look again |
Gentle reminder on this @tatilepizs @lorerod - Kindly review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rafa
I left some comments
Thanks for the feedback @tatilepizs i have made the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for being so patient and so open to suggestions ⭐
The tasks tests are failing due to compileTasks
because not for all the tests we can sync, there are some of them where the user is not logged in when we update the settings, so we can't sync at that moment.
I left suggestions about how to fix them
But everything else looks great 🚀
Description
#9443
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.