fix(#9481): improve style of new menu buttons and labels #9545
Conversation
latin-panda
changed the title
webapp/src/css/inbox.less
Outdated
| .panel-header-close { | ||
| width: 48px !important; | ||
| } |
There was a problem hiding this comment.
Same advice, to remove !important name the selector more specific, in L1418 .mat-sidenav mm-panel-header {
Then remove the !important
| .panel-header-close { | |
| width: 48px !important; | |
| } | |
| .panel-header-close { | |
| width: 48px; | |
| } |
There was a problem hiding this comment.
Cant do, it just don't apply those changes no matter hard i tried.
webapp/src/css/inbox.less
Outdated
| mat-icon { | ||
| margin-left: -6px !important; | ||
| } |
There was a problem hiding this comment.
Follow the same trick here, more specific selector and we can remove !important
| mat-icon { | |
| margin-left: -6px !important; | |
| } | |
| .nav-item mat-icon { | |
| margin-left: -6px; | |
| } |
webapp/src/css/inbox.less
Outdated
| .app-root:not(.old-nav) .header .tabs a .button-label { | ||
| /* Keep the desired styles */ | ||
| margin-top: 3px; | ||
| overflow: hidden; | ||
| word-wrap: break-word; | ||
| color: @nav-icon-gray; | ||
| font-size: @font-XXS; | ||
| text-overflow: ellipsis; | ||
|
|
||
| /* Unset or override the unwanted properties */ | ||
| display: block; | ||
| white-space: unset; | ||
| word-break: unset; | ||
| -webkit-line-clamp: unset; | ||
| -webkit-box-orient: unset; | ||
| line-clamp: unset; | ||
| } |
There was a problem hiding this comment.
Please move this into L1499, which is pretty much the same selector.
Then, remove the comments and duplicate attributes.
|
Hi @GallyTi were you able to address the feedback from the changes @latin-panda requested ? Do you need any support ? |
|
Hi @Benmuiruri :) . I was curious myself why i haven't get any new update. It turns out, maybe i didn't call Latin panda that the MR is repaired ass suggested, only some part of it. So I am sorry, @latin-panda can you please look at the comments I left on each comment you gave and look for changes, thank you :) |
|
No worries @GallyTi I will review it tomorrow first thing. @latin-panda is away for a couple of days |
There was a problem hiding this comment.
Hi @GallyTi thanks for making the changes.
This is pretty close. I left a few comments, once those are resolved this will be ready to merge.
Co-authored-by: Ben Kiarie <[email protected]>
Co-authored-by: Ben Kiarie <[email protected]>
|
@Benmuiruri Sorry for late response. It should be now good, sorry for troubles :/ |
Co-authored-by: Jennifer Q <[email protected]>
| -webkit-line-clamp: unset; | ||
| -webkit-box-orient: unset; | ||
| line-clamp: unset; |
There was a problem hiding this comment.
Hi @GallyTi I'm curious whether we need these?
These styles are causing misalignment of the labels.
Description
chore: improve style of menu buttons and labels #9533
This is Requested changes to #9481. But because there was so many things wrong i decided to make it from scratch, with new branch from master.
#9481
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.