chore(#9582): update datasource bind to not return promise

[jkuester]

Description

Closes #9582

See issue for details about the change.

Code review checklist

• Readable: Concise, well named, follows the style guide, documented if necessary.
• Tested: Unit and/or e2e where appropriate
• Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

• Core
• CouchDB Single
• CouchDB Cluster

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[garethbowen]

Nice improvement on the API!

One readability suggestion in the implementation.

[garethbowen]

Personally I find the autoreturn style with multi line body really difficult to follow. Is this just me?

Secondly I think you can remove an indent from lines 113 and 114. My suggestion would be...

Suggested change

	return (...p) => new Promise((resolve, reject) => this
	.isInitialized()
	.then(() => this.dataContext
	.bind(fn)(...p)
	.then(resolve)
	.catch(reject))) as ReturnType<F>;
	return (...p) => new Promise((resolve, reject) => {
	return this.isInitialized()
	.then(() => this.dataContext.bind(fn)(...p))
	.then(resolve)
	.catch(reject)) as ReturnType<F>;
	});

I think I got all the braces right...

[jkuester]

😅 Generally I don't mind autoreturns for promise chains (and other places where it is pretty clear where things are going). But, yeah, for this craziness we should make it as readable as possible (even if it means I actually have to type return a few more times.... 😭 ).

Going to take this a couple steps further and explicitly return the constructed Promise as well as assigning the contextual function to a variable to avoid the double-parenthesis from the currying. 👍

[Benmuiruri]

Is that TS code less Janky 😅 ?

I need to do more TS exercism.

But thanks for this, hides the initialization and just gives the function one wants to call.

[jkuester]

@Benmuiruri 😆 I should have been more specific! This makes the code consuming cht-datasoure less janky (by encapsulating all the jankyness into the bind function....) 🤦