Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#138): move polling to openhim channel config #139

Merged
merged 15 commits into from
Oct 25, 2024
Merged

feat(#138): move polling to openhim channel config #139

merged 15 commits into from
Oct 25, 2024

Conversation

witash
Copy link
Contributor

@witash witash commented Oct 8, 2024

making PRs against openmrs_mediator instead of just pushing to openmrs_mediator directly, to make review easier

closes #138

njuguna-n
njuguna-n reviewed Oct 9, 2024
View reviewed changes
Copy link

@njuguna-n njuguna-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments and questions

mediator/config/index.ts Outdated Show resolved Hide resolved
mediator/config/index.ts Outdated Show resolved Hide resolved
mediator/src/controllers/openmrs.ts Outdated Show resolved Hide resolved
mediator/src/controllers/openmrs.ts Show resolved Hide resolved
lorerod
lorerod requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @witash, for this work. I left some suggestions inline.

mediator/src/routes/openmrs.ts Outdated Show resolved Hide resolved
mediator/src/controllers/openmrs.ts Show resolved Hide resolved
njuguna-n
njuguna-n previously requested changes Oct 14, 2024
View reviewed changes
Copy link

@njuguna-n njuguna-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions. There is also a Sonar failure that should be fixed.

mediator/config/index.ts Outdated Show resolved Hide resolved
mediator/index.ts Outdated Show resolved Hide resolved
mediator/test/workflows.spec.ts Outdated Show resolved Hide resolved
@witash witash mentioned this pull request Oct 21, 2024
Open
@witash witash requested a review from lorerod October 23, 2024 11:22
lorerod
lorerod approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @witash! Left a minor comment.

mediator/test/workflows.spec.ts Outdated Show resolved Hide resolved
@witash witash merged commit d8cb295 into openmrs-mediator Oct 25, 2024
3 checks passed
@witash witash deleted the 138-make-openmrs-configureable branch October 25, 2024 12:25
@andrablaj andrablaj mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorerod lorerod lorerod approved these changes

@njuguna-n njuguna-n njuguna-n left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@witash @lorerod @njuguna-n