Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#29): Add data audit brac models #37

Closed
wants to merge 3 commits into from

Conversation

lorerod
Copy link
Contributor

@lorerod lorerod commented Nov 7, 2023

Add data audit to BRAC dbt models

@lorerod lorerod changed the base branch from main to BRAC-models November 7, 2023 17:11
@lorerod
Copy link
Contributor Author

lorerod commented Nov 17, 2023

@njuguna-n I implemented audits for both impact_pncview_visit and impact_pncview_expected_enrollments using only the macro compare_queries. Do you think using this macro is enough? Love to know your thoughts.
Also, will you want me to continue with all the PNC models? Or are you already making progress on those?

@andrablaj
Copy link
Member

@lorerod & @njuguna-n, can you please support with answering the following questions:

  • Is the approach started by @lorerod supporting the needs of this activity?
  • What are the remaining models to audit?

@lorerod
Copy link
Contributor Author

lorerod commented Apr 12, 2024

Is the approach started by @lorerod supporting the needs of this activity?

I started implementing auditing macros using the 'audit_helper' package. This package's primary purpose is to help with the table auditing process and ensure that a refactored model provides the same output as the original one. Although it is not useful for the comparison we are doing now between couch2pg queries and cht-pipeline models, it will be helpful when we refactor existing models. However, as priorities changed, I decided to help Njuguna by providing a manual comparison of the widgets and data sources.

What are the remaining models to audit?

I only implemented three models, so much remains to be done.

To keep things organized, I'm going to separate this PR from the Data audit for BRAC models issue and initiate a new issue for audit for refactoring purposes. We can prioritize it for later.

@lorerod
Copy link
Contributor Author

lorerod commented Apr 12, 2024

Also, I will make that issue related to the default models, not the BRAC models.

@lorerod
Copy link
Contributor Author

lorerod commented Apr 12, 2024

Issue created. I will use this draft PR as an example of how to implement auditing on models at #80

@andrablaj
Copy link
Member

@lorerod given the pipeline model changes, is this PR still relevant?

@lorerod
Copy link
Contributor Author

lorerod commented Sep 3, 2024

This PR is not relevant anymore. Thanks, @andrablaj, for the cleanup.

@lorerod lorerod closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants