Fix crash when replacing a user even if the place has no primary cont…

…act (#174)

1.3.19

package.json

@@ -1,6 +1,6 @@
 {
   "name": "cht-user-management",
-  "version": "1.3.18",
+  "version": "1.3.19",
   "main": "dist/index.js",
   "dependencies": {
     "@fastify/autoload": "^5.8.0",

src/lib/cht-api.ts

@@ -85,11 +85,13 @@ export class ChtApi {
     delete payloadClone.contact;
     delete payloadClone.parent;
 
-    const previousPrimaryContact = doc.contact._id;
+    const previousPrimaryContact = doc.contact?._id;
     Object.assign(doc, payloadClone, { contact: { _id: contactId }});
     doc.user_attribution ||= {};
     doc.user_attribution.previousPrimaryContacts ||= [];
-    doc.user_attribution.previousPrimaryContacts.push(previousPrimaryContact);
+    if (previousPrimaryContact) {
+      doc.user_attribution.previousPrimaryContacts.push(previousPrimaryContact);
+    }
 
     const putUrl = `medic/${payload._id}`;
     console.log('axios.put', putUrl);

src/services/upload.replacement.ts

@@ -23,7 +23,7 @@ export class UploadReplacementWithDeletion implements Uploader {
     }
 
     const updatedPlaceDoc = await retryOnUpdateConflict<any>(() => this.chtApi.updatePlace(payload, contactId));
-    const previousPrimaryContact = updatedPlaceDoc.user_attribution.previousPrimaryContacts?.pop();
+    const previousPrimaryContact = updatedPlaceDoc.user_attribution?.previousPrimaryContacts?.pop();
     if (previousPrimaryContact) {
       await retryOnUpdateConflict<any>(() => this.chtApi.deleteDoc(previousPrimaryContact));
     }

test/services/upload-manager.spec.ts

@@ -332,6 +332,32 @@ describe('services/upload-manager.ts', () => {
     });
     expect(place.isCreated).to.be.true;
   });
+
+  it('#173 - replacement when place has no primary contact', async () => {
+    const { remotePlace, sessionCache, contactType, fakeFormData, chtApi } = await createMocks();
+    const toReplace: RemotePlace = {
+      id: 'id-replace',
+      name: 'to-replace',
+      lineage: [remotePlace.id],
+      type: 'remote',
+    };
+
+    chtApi.updatePlace.resolves({ _id: 'updated-place-id' });
+    fakeFormData.hierarchy_replacement = toReplace.name;
+
+    chtApi.getPlacesWithType
+      .resolves([remotePlace])
+      .onSecondCall()
+      .resolves([toReplace]);
+
+    const place = await PlaceFactory.createOne(fakeFormData, contactType, sessionCache, chtApi);
+    expect(place.validationErrors).to.be.empty;
+
+    const uploadManager = new UploadManager();
+    await uploadManager.doUpload([place], chtApi);
+    expect(chtApi.deleteDoc.callCount).to.eq(0);
+    expect(place.isCreated).to.be.true;
+  });
 });
 
 async function createChu(remotePlace: RemotePlace, chu_name: string, sessionCache: any, chtApi: ChtApi) {