Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#158): integration of user management tool into civ project #164

Merged

Conversation

aloundoye
Copy link
Member

#158: integrate the user management tool into the CIV project as discussed in https://github.com/medic/config-moh-civ/issues/163.

@aloundoye aloundoye linked an issue May 3, 2024 that may be closed by this pull request
@aloundoye
Copy link
Member Author

Hi @inromualdo can you check if the contacts needed are added?
@kennsippell your feedback will be appreciated

Copy link
Member

@kennsippell kennsippell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

src/config/chis-civ/config.json Outdated Show resolved Hide resolved
src/config/chis-civ/config.json Show resolved Hide resolved
src/config/chis-civ/config.json Outdated Show resolved Hide resolved
src/config/chis-civ/config.json Outdated Show resolved Hide resolved
src/config/chis-civ/logo.png Outdated Show resolved Hide resolved
src/config/chis-civ/config.json Show resolved Hide resolved
src/config/chis-civ/config.json Show resolved Hide resolved
src/config/chis-civ/config.json Outdated Show resolved Hide resolved
@aloundoye
Copy link
Member Author

Hi both,
@kennsippell sorry for the delay I implemented your feedback, thanks.
@inromualdo is it good on your side?

Copy link
Contributor

@inromualdo inromualdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I left some comments

src/config/chis-civ/config.json Outdated Show resolved Hide resolved
src/config/chis-civ/config.json Show resolved Hide resolved
@aloundoye aloundoye requested a review from inromualdo May 15, 2024 17:35
@kennsippell
Copy link
Member

@aloundoye @inromualdo What is the status here? Are we stalled?
Are you working together for approval or should I review and approve?

@aloundoye
Copy link
Member Author

Hi @kennsippell, just waiting for approval from @inromualdo who requested some changes.

Copy link
Contributor

@inromualdo inromualdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aloundoye , we're good on this.
Thank you

@aloundoye aloundoye merged commit 4d93578 into main Jun 19, 2024
1 check passed
@aloundoye aloundoye deleted the 158-integration-of-user-management-tool-into-civ-project branch June 19, 2024 16:16
aloundoye added a commit that referenced this pull request Sep 17, 2024
* fix(#199): moh civ user management tool issues (#200)

* fix(#199): remove duplicate first name

fix medic/config-moh-civ#200

* fix(#199): remove required country area in phone

fix medic/config-moh-civ#200

* fix(#199): add grand parent level on the hierarchy

fix medic/config-moh-civ#200

* fix(#199): add supervision level on the hierarchy

(cherry picked from commit 0c6060f)

* Add hint to contact properties (#201)

(cherry picked from commit 59b5a2d)

* fix(#203): update civ config (#204)

* feat(#158): integration of user management tool into civ project (#164)

---------

Co-authored-by: Alassane Ndoye <[email protected]>
Co-authored-by: paulpascal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration of User Management Tool into CIV Project
3 participants