Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9): adds support for CouchDb v2 #10

Merged
merged 8 commits into from
Jun 22, 2024
Merged

Conversation

dianabarsan
Copy link
Member

In CouchDb v2, the POST _session request must be loaded with both payload AND basic auth.
Adds matrix to test CouchDb 2 and CouchDb 3.
CouchDb 2 uses medic image because it incorporates security configs and reduces the overhead required in the tests.

@@ -87,7 +87,6 @@ describe(`integration with ${authType}`, async function () {
tempDb = getDb(tempDbName, auth, authType);

const collectLogs = await utils.getDockerContainerLogs();
await db.allDocs();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes this request ended up polluting the docker logs with an extra session request, because in CI the cookie that we generated in a previous test would have expired already.

@dianabarsan dianabarsan requested a review from witash June 21, 2024 14:39
Copy link

@witash witash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ran integration tests with couchdb:2 and couchdb:3.3.3 images, fails on main with couchdb:2 but passes on this branch

@dianabarsan dianabarsan merged commit f5040a4 into main Jun 22, 2024
12 checks passed
@dianabarsan dianabarsan deleted the 9-support-for-couch2 branch June 22, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants