#237 - Minor suggestions to improve the container image #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-82
force-pushed
the
feature/237-Minor-suggestions-to-improve-the-container-image
branch
from
584107b
to
25b6268
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #238 +/- ##
==========================================
Coverage 78.49% 78.49%
Complexity 550 550
==========================================
Files 138 138
Lines 2409 2409
Branches 147 147
==========================================
Hits 1891 1891
Misses 460 460
Partials 58 58 ☔ View full report in Codecov by Sentry. |
michael-82
force-pushed
the
feature/237-Minor-suggestions-to-improve-the-container-image
branch
from
25b6268
to
157da1b
Compare
11 tasks
michael-82
changed the title
michael-82
force-pushed
the
feature/237-Minor-suggestions-to-improve-the-container-image
branch
from
157da1b
to
71de0b1
Compare
juliangruendner
requested review from
alexanderkiel and
EmteZogaf
and removed request for
alexanderkiel
michael-82
force-pushed
the
feature/237-Minor-suggestions-to-improve-the-container-image
branch
7 times, most recently
from
cd617f2
to
2cb58cf
Compare
michael-82
force-pushed
the
feature/237-Minor-suggestions-to-improve-the-container-image
branch
2 times, most recently
from
fdbf06c
to
901436f
Compare
michael-82
force-pushed
the
feature/237-Minor-suggestions-to-improve-the-container-image
branch
from
901436f
to
1d95857
Compare
michael-82
force-pushed
the
feature/237-Minor-suggestions-to-improve-the-container-image
branch
2 times, most recently
from
8c32e15
to
65ee919
Compare
- reorder cmds to decrease img size - use user id instead of name - pin base image by digest - use docker metadata action - use alpine image
michael-82
force-pushed
the
feature/237-Minor-suggestions-to-improve-the-container-image
branch
from
65ee919
to
cd878b2
Compare
|
@michael-82 lgtm -> please merge and create a release |
michael-82
deleted the
feature/237-Minor-suggestions-to-improve-the-container-image
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would render #234 obsolete since it is included here.
Using the custom certificates feature included in the temurin image (as suggested in the issue) sadly does not work for non-root users ( adoptium/containers#464 )