Add support to build images with self signed or internal certificates #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to build the image with self signed or internal certificates if needed. This change should not break anything if no custom certificates are used.
The changes in the
Dockerfileallows to save trusted x509 certificates (.crt) files along the Dockerfile and rebuild the image. The certificate files will be copied into the image and the OS's trust store will be updated.The change in the
docker-entrypoint.shensures that requests are validated against the CA certificates of the images OS instead of the Mozilla CA bundle from thecertifiPython package (which is the default for currentrequestsversions).