Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): storybook upgrade from v5 to v6. #171

Closed
wants to merge 5 commits into from

Conversation

phoenixTW
Copy link
Contributor

affects: @medly-components/core, @medly-components/layout

Updated core, layout meta title in storybook.
Added addon-essentials to
storybook addon.

ISSUES CLOSED: #151

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Performance improves
  • Adding missing tests
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Storybook 5 is being used in medly components.

Fixes # (151)

Migrated to Storybook6

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context

Add any other context or screenshots about the feature pr here.

affects: @medly-components/core, @medly-components/layout

Updated core, layout meta title in storybook.
Added addon-essentials to
storybook addon.

ISSUES CLOSED: medly#151
affects: @medly-components/core, @medly-components/forms, @medly-components/layout

ISSUES CLOSED: medly#151
affects: @medly-components/core, @medly-components/forms, @medly-components/layout
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gmukul01
Copy link
Collaborator

We will pick it up after some time.

@gmukul01 gmukul01 closed this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: migrate to Storybook 6
2 participants