Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date and time picker issues #742

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Conversation

gmukul01
Copy link
Collaborator

affects: @medly-components/core, @medly-components/forms, @medly-components/utils

PR Checklist

Description

(Replace This Text: Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes and API changes)
  • Build changes
  • CI changes
  • Document content changes
  • Performance improvement
  • Add missing tests
  • Others (please describe)

How has this been tested?

(Replace This Text: Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.)

[ ] Test A

[ ] Test B

Fixes #<issue_number>

What is the current behaviour?

(Replace This Text: Please describe the current behaviour you are modifying, or link a relevant issue.)

What is the new behaviour?

(Replace This Text: Please describe the expected new behaviour.)

Does this PR introduce a breaking change?

  • Yes
  • No

Note: (Replace This Text: If this PR contains a breaking change please describe the impact and migration path for existing application.)

Additional context

(Replace This Text: Please describe any other related information or add screenshots of the PR.)

Checklist

  • My code follows the style guidelines of this project

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • My changes generate no new warnings

  • I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes

  • Any dependent changes have been merged and published in downstream modules

affects: @medly-components/core, @medly-components/forms, @medly-components/utils
Copy link

sonarcloud bot commented Jun 23, 2024

Copy link

nx-cloud bot commented Jun 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f1ec353. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@gmukul01 gmukul01 merged commit e3abf5c into master Jun 23, 2024
4 checks passed
@gmukul01 gmukul01 deleted the fix-date-and-time-picker-issues branch June 23, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant