Assert config/pkg version equality before startup

medtune · Aug 13, 2018 · dbc6bd8 · dbc6bd8
1 parent b9bece6
commit dbc6bd8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/cmd/start/server_cmd.go b/cmd/start/server_cmd.go
@@ -77,13 +77,13 @@ func runServer() {
 	var configuration *config.StartupConfig
 
 	if cfg, err := config.LoadConfigFromPath(configFile); err != nil {
-		log.Panic(err)
+		log.Fatal(err)
 	} else {
 		configuration = cfg
 	}
 
 	if err := initpkg.InitFromConfig(configuration); err != nil {
-		log.Panic(err)
+		log.Fatal(err)
 	}
 
 	if syncdb {
@@ -102,7 +102,7 @@ func runServer() {
 			}
 		}
 		if err != nil {
-			panic(err)
+			log.Fatal(err)
 		}
 		fmt.Println("connected to database...")
 	}

diff --git a/config.local.yml b/config.local.yml
@@ -1,6 +1,7 @@
 meta:
   name: medtune beta platform
-  description: beta test
+  description: medtune beta test
+  version: v0.1.1
   prod: true
 
 database:

diff --git a/pkg/initpkg/init.go b/pkg/initpkg/init.go
@@ -1,8 +1,10 @@
 package initpkg
 
 import (
+	"fmt"
 	"log"
 
+	"github.com/medtune/beta-platform/pkg"
 	"github.com/medtune/beta-platform/pkg/service/capsul"
 
 	tfsclient "github.com/medtune/capsul/pkg/tfs-client"
@@ -15,7 +17,7 @@ import (
 	"github.com/medtune/go-utils/random"
 )
 
-// Init packages from configuration file
+// InitFromFile from configuration file
 func InitFromFile(file string) error {
 	config, err := config.LoadConfigFromPath(file)
 	if err != nil {
@@ -31,6 +33,10 @@ func InitFromFile(file string) error {
 
 // InitFromConfig uration file
 func InitFromConfig(c *config.StartupConfig) error {
+	// Check version
+	if c.Meta.Version != pkg.VERSION {
+		return fmt.Errorf("Configuration meta version did'nt match\n\tpackage version: %v\n\tconfigs version: %v", pkg.VERSION, c.Meta.Version)
+	}
 	// init package pkg/session
 	if err := initSession(c.Session); err != nil {
 		return err