Issuing a build warning if the user has secure boot enabled but… #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t appear to have a signing key enrolled yet. This can happen if, for example, it is the first time a user has compiled a kernel mod or if they have previously used akmods instead of dkms (eg, Fedora) Adding a small blurb to the README giving an overview of what this might mean and what to do. I believe this is important because nearly every hit when Googling for "xone" "secure boot" reads like a horror story where people abandon secure boot, abandon xone, or both
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your fantastic software! I did not think the dongle would EVER be supported. Great to finally feel like it's no longer necessary to recommend the 360 dongle after all these years.
Your use of dkms is perfect, but the way that the software will silently create new self-signed keys can be a bit of a gotcha to someone using secure boot (eg, https://www.reddit.com/r/linux_gaming/comments/1as5tos/xone_doesnt_work/). It's beyond the scope of this project to dive deep on security, but it is IMHO appropriate to at least offer some breadcrumbs.
To that end, I have added a build warning for the case that a user has secure boot enabled but doesn't yet have keys in the default locations (eg, someone coming from akmods). I've also added a small blurb to the troubleshooting section of the README giving an overview of what this might mean and what to do. I believe these changes could be invaluable to novice and intermediate users until such time as your wonderful package becomes canonized by distros or the kernel itself.
Cheers!