Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add derivation-generation logic to import.js #47

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bt2901
Copy link
Contributor

@bt2901 bt2901 commented Jun 11, 2024

Processed 18458 records...
Added 21622 derived word forms.
408 derived words already exist.

The result is strings like these added to some files:

nouns-neuter.json:
["32631>0","#n.vnoun.","žžeńje",""],
["29639>0","#n.vnoun.","oslěpnųťje",""],
["14817>0","#n.vnoun.","osloženjeńje",""],
["7>0","#n.vnoun.","osųđańje",""],

adjectives.json:
["4475>1","#adj.ptcp.","sȯvětujųćí",""],
["4475>2","#adj.ptcp.","sȯvětujemý",""],
["4475>3","#adj.ptcp.","sȯvětovavši",""],
["4475>4","#adj.ptcp.","sȯvětovaný",""],
["1907>0","#adj.comp.","speciaľnějši",""],
["1907>1","#adj.comp.","najspeciaľnějši",""],

Some care was taken to exclude multiword expressions like

["35354>0","#n.vnoun.","ne ljubjeńje",""],
["1398>0","#adj.comp.","bolje sovětski",""],
["1398>1","#adj.comp.","najbolje sovětski",""],

and "forbidden" verb participles (e.g. "spimy").

Some statistics. Out of 408 "already existing" words, 393 are verbal nouns like "rěšeńje". The rest are:

pfap: [ 'byvši', 'krasivši', 'legši', 'zabolěvši' ]
comparative: [
  'blizši',   'lučši',  'glųbši',   'legši',
  'menši',    'nizši',  'starějši', 'širši',
  'vysši',    'gorši'
]
superlative: [ 'najstarějši' ]

Apparently, the statistics do not take into account entries like starějši, starši. I'm not sure how bad is it.

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9474008240

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.36%

Totals Coverage Status
Change from base Build 9160404496: 0.0%
Covered Lines: 1630
Relevant Lines: 1708

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9506583270

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.36%

Totals Coverage Status
Change from base Build 9160404496: 0.0%
Covered Lines: 1630
Relevant Lines: 1708

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9506792545

Details

  • 1 of 10 (10.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 91.895%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/verb/conjugationVerb.ts 1 10 10.0%
Totals Coverage Status
Change from base Build 9160404496: -0.5%
Covered Lines: 1631
Relevant Lines: 1718

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants