Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove slow utils #56

Merged
merged 1 commit into from
Jun 23, 2024
Merged

refactor: remove slow utils #56

merged 1 commit into from
Jun 23, 2024

Conversation

noomorph
Copy link
Contributor

matchEnd and matchStart turned out to x3 slower than regular expressions, so removing them... πŸ€·β€β™‚οΈ

All tests pass.

@coveralls
Copy link

coveralls commented Jun 23, 2024

Pull Request Test Coverage Report for Build 9636183274

Details

  • 34 of 34 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.365%

Totals Coverage Status
Change from base Build 9636113808: -0.1%
Covered Lines: 1657
Relevant Lines: 1736

πŸ’› - Coveralls

@noomorph noomorph merged commit 25e9f63 into main Jun 23, 2024
1 check passed
@noomorph noomorph deleted the refactor/remove-some-utils branch June 23, 2024 20:35
Copy link
Contributor

πŸŽ‰ This PR is included in version 3.1.7 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants