Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend-GNOME: remove --debug flag from launcher script #300

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

knocte
Copy link
Contributor

@knocte knocte commented Apr 16, 2024

This would be making Smuxi much slower than it needs to; since many optimizations may not be enabled when running in debug mode.

If a developer wants to still run in debug mode after this, she still has two options:

a) Use make run which still launches smuxi with the --debug flag.

b) Export env var MONO_OPTIONS=--debug before launching smuxi.

This would be making Smuxi much slower than it needs to; since
many optimization may not be enabled when running in debug mode.

If a developer wants to still run in debug mode after this, she
still has two options:

a) Use `make run` which still launches smuxi with the --debug flag.

b) Export env var `MONO_OPTIONS=--debug` before launching smuxi.
@meebey meebey merged commit fbcc411 into meebey:master Apr 17, 2024
8 of 10 checks passed
@knocte
Copy link
Contributor Author

knocte commented Apr 18, 2024

@meebey thanks for merging so quickly, btw did you notice the red CI lanes? the Debian unstable one I'm aware of, but see the nix one? how could we fix that for newer PRs, restricting to github.ref values of 'master' and 'stable' for example?

@meebey
Copy link
Owner

meebey commented Apr 21, 2024

@knocte thanks for raising. the unstable build failure is known because of Debian's GTK#2 removal. The nix build failure seems to have something to do that pulling this PR isn't working. Not sure why though, PR should be a regular branch that you can check out.

@meebey
Copy link
Owner

meebey commented Apr 21, 2024

The GitHub action invokes:
pkgs.callPackage ./nix/default.nix { gitBranch = "${{ github.ref_name }}"; }'

github.ref_name is set by GitHub and is "300/merge" according to the build output.

Nix then attempts to fetch that branch via:

  src = fetchGit {
    url = "https://github.com/meebey/smuxi.git";
    ref = gitBranch;
    submodules = true;
  };

That call fails with:
fatal: couldn't find remote ref refs/heads/300/merge

Either 300/merge is not a valid branch ref of the github.com/meebey/smuxi git repo, or it doesn't like/cope with the "/" in the branch name.

@knocte
Copy link
Contributor Author

knocte commented Apr 22, 2024

Either 300/merge is not a valid branch ref of the github.com/meebey/smuxi git repo, or it doesn't like/cope with the "/" in the branch name.

In order to test your hypothesis above, I have pushed the same commit of this PR but to a new branch in my fork called "noDebug" (instead of "wip/noDebug", like I originally did; or if you look at it from the PR-CI point of view, "300/merge"), but CI is still broken, this time with this error: https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528

Which I paste here:

Run nix-build --expr 'let pkgs = import <nixpkgs> { }; in pkgs.callPackage ./nix/default.nix { gitBranch = "noDebug"; }'
  nix-build --expr 'let pkgs = import <nixpkgs> { }; in pkgs.callPackage ./nix/default.nix { gitBranch = "noDebug"; }'
  shell: sh -e {0}
warning: $HOME ('/github/home') is not owned by you, falling back to the one defined in the 'passwd' file ('/root')
fatal: couldn't find remote ref refs/heads/noDebug
warning: could not update mtime for file '/root/.cache/nix/gitv3/0dlgrxhb3sw67bjmryck4mpsz6y189idaxg7vrcm45p[2](https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528#step:4:2)vw1m665g/refs/heads/noDebug': No such file or directory
error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:9:12:
            8|
            9|   strict = derivationStrict drvAttrs;
             |            ^
           10|

       … while evaluating derivation 'smuxi-1.2.1'
         whose name attribute is located at /nix/store/wj8[3](https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528#step:4:3)y3qvj8v29d5zz0fih03682jf6qr1-b9zng82injl[4](https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528#step:4:5)hg2cywz0ql8s9jiylnw0-source/pkgs/stdenv/generic/make-derivation.nix:348:7

       … while evaluating attribute 'src' of derivation 'smuxi-1.2.1'
         at /__w/smuxi/smuxi/nix/default.nix:24:3:
           23|
           24|   src = fetchGit {
             |   ^
           2[5](https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528#step:4:6)|     url = "https://github.com/meebey/smuxi.git";

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: opening file '/root/.cache/nix/gitv3/0dlgrxhb3sw[6](https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528#step:4:7)7bjmryck4mpsz6y189idaxg7vrcm45p2vw1m665g/refs/heads/noDebug': No such file or directory
Error: Process completed with exit code 1.

Is the real issue more clear now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants