CV2-5138: Data Dashboard: Write and analyze queries #2033
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lib/check_data_points.rb
Outdated
| smooch_request_type: SEARCH_RESULT_TYPES, | ||
| created_at: start_date..end_date, | ||
| ).count | ||
| c2 = TiplineRequest |
There was a problem hiding this comment.
Suggestion: For clarity, please rename this variable and/or add a comment that explains that "this is the number of articles sent as reports".
lib/check_data_points.rb
Outdated
| created_at: start_date..end_date, | ||
| ).count | ||
| c2 = TiplineRequest | ||
| .where(smooch_request_type: ["default_requests", "timeout_requests"]) |
There was a problem hiding this comment.
@melsawy , I was thinking more about it, I think that we don't need this condition here. Because for a situation that a search result was returned but then an updated report was sent, I think we still want to count that.
@brianfleming , if you can confirm, please... imagine this situation:
- User sends a query
- The query returns a search result - this increments the statistics of "articles sent" by 1
- That same report is updated later on, and the user receives an update report - should this also increment "articles sent" by 1?
There was a problem hiding this comment.
yes @caiosba I agree. It matches with another discussion we had on analytics counting. starting with counting all the things now is a good idea. later if we need to get more specific we can
lib/check_data_points.rb
Outdated
| def elastic_search_top_items(team_id, start_date, end_date, limit, with_tags = false) | ||
| data = {} | ||
| query = { | ||
| range: {'created_at': { start_time: start_date, end_time: end_date } }, | ||
| demand: { min: 1 }, | ||
| sort: 'demand', | ||
| eslimit: limit | ||
| } | ||
| query[:tags_as_sentence] = { min: 1 } if with_tags | ||
| result = CheckSearch.new(query.to_json, nil, team_id) | ||
| result.medias.each{|pm| data[pm.id] = pm.demand } | ||
| data | ||
| end | ||
| end |
Done |
melsawy
deleted the
CV2-5138-data-dashboard-write-and-analyze-queries
branch
Description
Add a class for data points
References: CV2-5138
How has this been tested?
Implemented automated tests.
Things to pay attention to during code review
Please describe parts of the change that require extra attention during code review, for example:
Checklist