Make ProjectMedia.set_original_claim work as expected for a video URL with arguments
#2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…URL with arguments. This PR fixes a bug with `ProjectMedia.set_original_claim` attribute for video URLs that contained arguments, for example: https://test.xyz/video.mp4?foo=bar. The item wouldn't be created, since the extension validation would fail. The fix is to use `File.ext` over the URL path, not the full URL, since the former strips the arguments, while the latter contains them. Fixes: CV2-5232.
caiosba
requested review from
melsawy,
DGaffney and
jayjay-w
as code owners
caiosba
changed the title
ProjectMedia.set_original_claim works as expected for a video URL with argumentsProjectMedia.set_original_claim work as expected for a video URL with arguments
melsawy
approved these changes
Sep 17, 2024
amoedoamorim
approved these changes
Sep 17, 2024
caiosba
deleted the
fix/CV2-5232-set-original-claim-media-from-url-with-arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug with
ProjectMedia.set_original_claimattribute for video URLs that contained arguments, for example: https://test.xyz/video.mp4?foo=bar. The item wouldn't be created, since the extension validation would fail.The fix is to use
File.extnameover the URL path only, not the full URL, since the former strips the arguments, while the latter contains them.Fixes: CV2-5232.
How has this been tested?
TDD. I was able to reproduce the bug in a unit test contained in this PR. The test passed once the fix was implemented.
Things to pay attention to during code review
At some point, we may get rid of
File.extnamealtogether and instead rely on the content-type response header in order to extract the extension.Checklist