Need to split the maximum size for tipline content video files. #2048
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need one maximum size for the Check upload and another one that is actually the maximum size supported by WhatsApp. Fixes: CV2-5326.
caiosba
requested review from
melsawy,
DGaffney and
jayjay-w
as code owners
melsawy
approved these changes
Sep 24, 2024
| def header_file_video_max_size | ||
| # Max size that WhatsApp supports | ||
| def header_file_video_max_size_whatsapp | ||
| 16 |
There was a problem hiding this comment.
It's better to read the value from config not hard coded
| end | ||
|
|
||
| # Max size for Check (we need to convert it to H.264, so let's be safe) | ||
| def header_file_video_max_size_check | ||
| 10 |
There was a problem hiding this comment.
It's better to read the value from config not hard coded
jayjay-w
approved these changes
Sep 24, 2024
|
Thanks guys, I turned those into configuration keys. |
caiosba
deleted the
fix/CV2-5326-validate-video-size-after-converting-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need one maximum size for the Check upload and another one that is actually the maximum size supported by WhatsApp. This separation is needed because we need to convert the uploaded video to H.264, which is the codec support by WhatsApp. So we need a safe margin for that.
Fixes: CV2-5326.
How has this been tested?
Unit test updated.
Checklist