Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5005: Sentry issue related to ES #2057

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Sep 29, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context – why has this been changed/fixed.

References: CV2-5005

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@melsawy melsawy marked this pull request as ready for review September 30, 2024 17:12
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melsawy , as far as I understand, your approach here is to save only the fields that actually have changed in that update by that specific request/thread, right?

app/models/concerns/project_association.rb Show resolved Hide resolved
test/models/project_media_3_test.rb Outdated Show resolved Hide resolved
@melsawy
Copy link
Contributor Author

melsawy commented Sep 30, 2024

@melsawy , as far as I understand, your approach here is to save only the fields that actually have changed in that update by that specific request/thread, right?

Right @caiosba

@melsawy melsawy merged commit 1237fc2 into develop Oct 1, 2024
11 checks passed
@melsawy melsawy deleted the fix/CV2-5005-sentry-issue branch October 1, 2024 01:59
DGaffney pushed a commit that referenced this pull request Oct 15, 2024
* CV2-5005: limit ES date to updated fields only

* CV2-5005: fix tests

* CV2-5005: test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants