Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset item status to default one when claim/fact-check is detached. #2064

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Reset item status to default one when claim/fact-check is detached. #2064

merged 1 commit into from
Oct 2, 2024
+87 −0

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Oct 1, 2024

Description

Reset item status to default one when claim/fact-check is detached.

Fixes CV2-4502.

How has this been tested?

Automated tests added for two cases: workspace with core statuses and workspace with custom statuses.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

DGaffney
DGaffney approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@DGaffney DGaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@caiosba caiosba merged commit 1e56f87 into develop Oct 2, 2024
11 checks passed
@caiosba caiosba deleted the fixes/CV2-4502-articles-trash branch October 2, 2024 01:08
DGaffney pushed a commit that referenced this pull request Oct 15, 2024
@caiosba @DGaffney
Reset item status to default one when claim/fact-check is detached. (#…
d98cff3 
…2064)

Fixes CV2-4502.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DGaffney DGaffney DGaffney approved these changes

@melsawy melsawy Awaiting requested review from melsawy melsawy is a code owner

@jayjay-w jayjay-w Awaiting requested review from jayjay-w jayjay-w is a code owner

@vasconsaurus vasconsaurus Awaiting requested review from vasconsaurus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caiosba @DGaffney