Add skip_cache parameter to bypass similarity search cache in Feed API #2095
+31
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiosba
reviewed
Oct 17, 2024
Comment on lines
60
to
64
| if skip_cache | ||
| results = Bot::Smooch.search_for_similar_published_fact_checks_no_cache(type, query, feed.team_ids, after, feed_id) | ||
| else | ||
| results = Bot::Smooch.search_for_similar_published_fact_checks(type, query, feed.team_ids, after, feed_id) | ||
| end |
There was a problem hiding this comment.
@jayjay-w as per our conversation, let's move this logic to inside Bot::Smooch.search_for_similar_published_fact_checks - so, this is the method that can receive the skip_cache parameter and then bypass cache if true - please confirm if Rails.cache.fetch can take a force argument that bypasses cache.
There was a problem hiding this comment.
So it turns out there's no force option for Rails.cache.fetch, so I changed this to use a conditional if.
- Introduced `skip_cache` parameter to Feed API, allowing requests to bypass the similarity search cache when set to `true`. - Updated `search_for_similar_published_fact_checks` in `SmoochSearch` to support cached and non-cached search logic. - Added `search_for_similar_published_fact_checks_no_cache` method to perform non-cached similarity searches. - Modified `FeedResource` to handle and pass the `skip_cache` parameter. - Implemented automated test for `skip_cache` functionality to ensure correct behavior. - Updated logging for better traceability of cache usage in similarity searches.
jayjay-w
force-pushed
the
CV2-5400-add-skip-cache-param
branch
from
5a4d4f5
to
1e7eb7a
Compare
jayjay-w
force-pushed
the
CV2-5400-add-skip-cache-param
branch
from
1e7eb7a
to
7c0240d
Compare
caiosba
requested changes
Oct 20, 2024
melsawy
reviewed
Oct 20, 2024
caiosba
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
skip_cacheparameter to Feed API, allowing requests to bypass the similarity search cache when set totrue.search_for_similar_published_fact_checksinSmoochSearchto support cached and non-cached search logic.search_for_similar_published_fact_checks_no_cachemethod to perform non-cached similarity searches.FeedResourceto handle and pass theskip_cacheparameter.References: CV2-2400
How has this been tested?
Ensured all existing tests are still passing
Things to pay attention to during code review
Check if anything was missed
Checklist