Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CV2-5250: Associate a caption as a text media with the media item #2096

Merged
merged 1 commit into from
Oct 17, 2024
Merged

CV2-5250: Associate a caption as a text media with the media item #2096

merged 1 commit into from
Oct 17, 2024

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Oct 17, 2024 •
edited
Loading

Description

Automatically associate a caption as a text media with the image media.

References: CV2-5250

How has this been tested?

Implemented automated tests.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

caiosba
caiosba approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-liners FTW

@melsawy melsawy merged commit d0b276b into develop Oct 17, 2024
11 checks passed
@melsawy melsawy deleted the CV2-5250-captions-as-media branch October 17, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caiosba caiosba caiosba approved these changes

@jayjay-w jayjay-w jayjay-w approved these changes

@DGaffney DGaffney Awaiting requested review from DGaffney DGaffney is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melsawy @caiosba @jayjay-w