Semantics: Changed "hide fails counter" to "show fails counter"

megalon · Feb 7, 2019 · 6f253cd · 6f253cd
1 parent 8e7b298
commit 6f253cd
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/BeatSaberTweaks/Settings.cs b/BeatSaberTweaks/Settings.cs
@@ -182,12 +182,12 @@ public class Settings
         public static bool ClickShockwaveEnable { get => instance.clickShockwaveEnable; set { instance.clickShockwaveEnable = value; Plugin.saveRequested = true; } }
 
         [SerializeField]
-        bool hideFailsCounter = true;
-        public static bool HideFailsCounterEnable { get => instance.hideFailsCounter; set { instance.hideFailsCounter = value; Plugin.saveRequested = true; } }
+        bool showFailsCounter = true;
+        public static bool ShowFailsCounterEnable { get => instance.showFailsCounter; set { instance.showFailsCounter = value; Plugin.saveRequested = true; } }
 
         [SerializeField]
-        string hideFailsReplacementText = "HIDDEN";
-        public static string HideFailsReplacementText { get => instance.hideFailsReplacementText; set { instance.hideFailsReplacementText = value; Plugin.saveRequested = true; } }
+        string failsCounterReplacementText = "HIDDEN";
+        public static string FailsCounterReplacementText { get => instance.failsCounterReplacementText; set { instance.failsCounterReplacementText = value; Plugin.saveRequested = true; } }
 
         public Settings()
         {

diff --git a/BeatSaberTweaks/TweakManager.cs b/BeatSaberTweaks/TweakManager.cs
@@ -230,15 +230,15 @@ private void CreateUI()
             enableRippleEffect.GetValue += delegate { return Settings.ClickShockwaveEnable; };
             enableRippleEffect.SetValue += delegate (bool value) { Settings.ClickShockwaveEnable = value; };
 
-            var hideFailsCounter = subMenuInterfaceTweaks3.AddBool("Hide fails counter");
-            hideFailsCounter.EnabledText = "YES";
-            hideFailsCounter.DisabledText = "NO";
-            hideFailsCounter.GetValue += delegate { return Settings.HideFailsCounterEnable; };
-            hideFailsCounter.SetValue += delegate (bool value) { Settings.HideFailsCounterEnable = value; };
+            var showFailsCounter = subMenuInterfaceTweaks3.AddBool("Fails counter", "If the fails counter number should be visible on the stats screen.");
+            showFailsCounter.EnabledText = "VISIBLE";
+            showFailsCounter.DisabledText = "HIDDEN";
+            showFailsCounter.GetValue += delegate { return Settings.ShowFailsCounterEnable; };
+            showFailsCounter.SetValue += delegate (bool value) { Settings.ShowFailsCounterEnable = value; };
 
             var hideFailsReplacementText = subMenuInterfaceTweaks3.AddString("Replacement Text", "The text to replace the fails counter with.");
-            hideFailsReplacementText.GetValue += delegate { return Settings.HideFailsReplacementText; };
-            hideFailsReplacementText.SetValue += delegate (string value) { Settings.HideFailsReplacementText = value; };
+            hideFailsReplacementText.GetValue += delegate { return Settings.FailsCounterReplacementText; };
+            hideFailsReplacementText.SetValue += delegate (string value) { Settings.FailsCounterReplacementText = value; };
 
             // Volume Tweaks
             var subMenuVolumeTweaks = SettingsUI.CreateSubMenu("Volume Tweaks");

diff --git a/BeatSaberTweaks/Tweaks/MenuTweaks/LevelsFailedTweak.cs b/BeatSaberTweaks/Tweaks/MenuTweaks/LevelsFailedTweak.cs
@@ -16,7 +16,7 @@ class LevelsFailedTweak : MonoBehaviour
         public static LevelsFailedTweak Instance;
 
         private PlayerStatisticsViewController stats;
-        private bool hideFailCounter = false;
+        private bool showFailCounter = false;
         private bool loaded = false;
         private TextMeshProUGUI _failedLevelsCountText;
         private string failedLevelsCountReplacementText = "HIDDEN";
@@ -76,14 +76,14 @@ private IEnumerator WaitForLoad()
         private void Init()
         {
             Plugin.Log("Initialized!", Plugin.LogLevel.DebugOnly);
-            failedLevelsCountReplacementText = Settings.HideFailsReplacementText;
+            failedLevelsCountReplacementText = Settings.FailsCounterReplacementText;
 
-            hideFailCounter = Settings.HideFailsCounterEnable;
+            showFailCounter = Settings.ShowFailsCounterEnable;
         }
 
         public void Update()
         {
-            if (hideFailCounter && loaded)
+            if (!showFailCounter && loaded)
             {
                 if (_failedLevelsCountText == null)
                 {