Implement vector search experimental feature v2 (v1.6) #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
requested changes
Feb 6, 2024
curquiza
added
enhancement
|
Putting |
sanders41
requested changes
Feb 6, 2024
Co-authored-by: Paul Sanders <[email protected]>
Co-authored-by: Paul Sanders <[email protected]>
sanders41
requested changes
Feb 7, 2024
There was a problem hiding this comment.
It's totally fine to put the new_embedders fixture in conftest.py so no need to move it back. Just as an FYI, the reason pylint was giving an error is because pylint is wrong 😄. That is why we have # pylint: disable=redefined-outer-name at the top of some other test files.
meili-bors bot
added a commit
that referenced
this pull request
Feb 7, 2024
924: Implement vector search experimental feature v2 (v1.6) r=sanders41 a=CaroFG # Pull Request ## Related issue Fixes #901 ## What does this PR do? - Creates embedders classes - Adds embedders to paths - Introduces new routes: - Create a new method to get the settings by calling GET /indexes/:index_uid/settings/embedders - Create a new method to update the settings by calling PATCH /indexes/:index_uid/settings/embedders - Create a new method to reset the settings by calling DELETE /indexes/:index_uid/settings/embedders - Adds embedders settings tests - Updates vector search tests ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: CaroFG <[email protected]> Co-authored-by: CaroFG <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
@curquiza do you know why bors would fail? When I look it say everything succeeded. Edit: bors added a comment and it looks like it wants you to approve also. |
curquiza
approved these changes
Feb 8, 2024
CommanderStorm
added a commit
to CommanderStorm/meilisearch-rust
that referenced
this pull request
Mar 8, 2024
4 tasks
CommanderStorm
added a commit
to CommanderStorm/meilisearch-rust
that referenced
this pull request
Mar 11, 2024
CommanderStorm
added a commit
to CommanderStorm/meilisearch-rust
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #901
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!