Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename top level module #585

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Conversation

ellnix
Copy link
Collaborator

@ellnix ellnix commented Jan 4, 2025

Pull Request

Related issue

Fixes #523

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d8facd1) to head (1ffa380).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #585   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          692       707   +15     
=========================================
+ Hits           692       707   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ellnix ellnix force-pushed the rename-top-level-module branch from 12c1ca5 to 59549c7 Compare January 4, 2025 23:11
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I loved the idea of soft deprecation 🤌

@curquiza
Copy link
Member

bors merge

@curquiza curquiza added the breaking-change The related changes are breaking for the users label Jan 10, 2025
@curquiza
Copy link
Member

It's not really breaking, since it's soft deprecation, but I want the users to see it clearly by increasing the minor

Copy link
Contributor

meili-bors bot commented Jan 10, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit 4d7a593 into meilisearch:main Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename root module to Meilisearch instead of MeiliSearch
3 participants