Skip to content

Commit

Permalink
Change some status to "Justified" or "Not a defect"; 5 less defects i…
Browse files Browse the repository at this point in the history
…n tests
  • Loading branch information
JokeWaumans committed Jul 25, 2024
1 parent e248258 commit 10b1b16
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 108 deletions.
12 changes: 6 additions & 6 deletions tests/test_in/polyspace.tsv
Original file line number Diff line number Diff line change
Expand Up @@ -25,28 +25,28 @@ ID Family Group Color New Check Information Function File Status Severity Commen
22036 Run-time Check Numerical Green no Overflow dummy_function() dummy_file_name.c Unreviewed Unset C4992326D32B4698C491 6 4
22065 Run-time Check Data flow Green no Non-initialized local variable dummy_function() dummy_file_name.c Unreviewed Unset C49953E693A45698C489 5 5
22035 Run-time Check Data flow Green no Non-initialized local variable dummy_function() dummy_file_name.c Unreviewed Unset C499232693A45698C491 5 6
21989 Run-time Check Numerical Green no Overflow dummy_function() dummy_file_name.c Unreviewed Unset C4997327D32B4698C881 6 7
21989 Run-time Check Numerical Green no Overflow dummy_function() dummy_file_name.c Not a defect Unset C4997327D32B4698C881 6 7
19928 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 62C8B1F4CA9126336A 6 8
19962 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 62D8A9F4CA91263472 7 9
19962 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Not a defect Unset 62D8A9F4CA91263472 7 9
19526 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C899F4CA9126316A 7 10
19424 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.h Unreviewed Unset 62E489F4CA91263262 6 11
19429 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.h Unreviewed Unset 62E4A1F4CA91263162 6 2
19429 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.h Justified Unset 62E4A1F4CA91263162 6 2
19442 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.h Unreviewed Unset 62C091F4CA91263170 7 3
19450 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.h Unreviewed Unset 62C091F4CA91263170 7 3
19450 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.h Justified Unset 62C091F4CA91263170 7 3
19375 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C089F4CA9126326C 8 4
19378 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C091F4CA9126316E 8 5
19377 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C091F4CA9126336A 7 6
19357 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C8A9F4CA91263368 7 7
19352 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C8A9F4CA91263760 8 8
19351 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C8A9F4CA91263862 8 9
19351 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Justified Unset 66C8A9F4CA91263862 8 9
19355 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C8A9F4CA91263962 9 10
19354 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset CC9153E995234C62C091 9 11
19358 Run-time Check Numerical Orange no Overflow Origin: Path related issue dummy_function() dummy_file_name.c Unreviewed Unset CC9153E995234C62C0C1 8 3
19360 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C8B1F4CA91263262 8 4
19349 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C8C1F4CA91263262 9 5
19345 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C8C1F4CA91263470 9 6
19344 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66C8C1F4CA91263572 10 7
19339 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66CC91F4CA91263464 10 8
19339 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Not a defect Unset 66CC91F4CA91263464 10 8
19338 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66CC91F4CA91263468 9 9
19336 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset 66CC91F4CA91263970 9 10
19335 Run-time Check Numerical Orange no Overflow dummy_function() dummy_file_name.c Unreviewed Unset CC9923E995234C62C0C9 10 11
Expand Down
70 changes: 0 additions & 70 deletions tests/test_in/polyspace_code_quality.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,6 @@
"description": "Polyspace: Overflow",
"fingerprint": "07bf7b7981eea1d6f5a95d69c9b0d05d"
},
{
"severity": "major",
"location": {
"path": "dummy_file_name.c",
"positions": {
"begin": {
"line": "7",
"column": "7"
}
}
},
"description": "Polyspace: Overflow",
"fingerprint": "29a5e4588709eb7271a30605d4fd3bd3"
},
{
"severity": "major",
"location": {
Expand Down Expand Up @@ -55,20 +41,6 @@
"description": "Polyspace: Overflow",
"fingerprint": "839e418eda6b091c2413aa0722796fb9"
},
{
"severity": "major",
"location": {
"path": "dummy_file_name.h",
"positions": {
"begin": {
"line": "6",
"column": "6"
}
}
},
"description": "Polyspace: Overflow",
"fingerprint": "cabd96c885bd6d9ed3fe867b227e8128"
},
{
"severity": "major",
"location": {
Expand All @@ -83,20 +55,6 @@
"description": "Polyspace: Overflow",
"fingerprint": "1961351c7f028d02202f915a6d36c658"
},
{
"severity": "major",
"location": {
"path": "dummy_file_name.h",
"positions": {
"begin": {
"line": "7",
"column": "7"
}
}
},
"description": "Polyspace: Overflow",
"fingerprint": "fb6455c4794157cb304be4106e115e35"
},
{
"severity": "major",
"location": {
Expand Down Expand Up @@ -167,20 +125,6 @@
"description": "Polyspace: Overflow",
"fingerprint": "e790d2d7f4e8fc2fb244ab0f74beca64"
},
{
"severity": "major",
"location": {
"path": "dummy_file_name.c",
"positions": {
"begin": {
"line": "8",
"column": "8"
}
}
},
"description": "Polyspace: Overflow",
"fingerprint": "2848e52a5925a6e7d35aacf6cbf5afed"
},
{
"severity": "major",
"location": {
Expand Down Expand Up @@ -279,20 +223,6 @@
"description": "Polyspace: Overflow",
"fingerprint": "591d152475bd60b07e0e7f00ec000229"
},
{
"severity": "major",
"location": {
"path": "dummy_file_name.c",
"positions": {
"begin": {
"line": "10",
"column": "10"
}
}
},
"description": "Polyspace: Overflow",
"fingerprint": "c1886be8c04e07b85f86f2571f0fa03d"
},
{
"severity": "major",
"location": {
Expand Down
28 changes: 0 additions & 28 deletions tests/test_in/polyspace_code_quality_exclude.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,6 @@
"description": "12345 Run-time Check: Overflow",
"fingerprint": "839e418eda6b091c2413aa0722796fb9"
},
{
"severity": "major",
"location": {
"path": "dummy_file_name.h",
"positions": {
"begin": {
"line": "6",
"column": "6"
}
}
},
"description": "12345 Run-time Check: Overflow",
"fingerprint": "cabd96c885bd6d9ed3fe867b227e8128"
},
{
"severity": "major",
"location": {
Expand All @@ -41,20 +27,6 @@
"description": "12345 Run-time Check: Overflow",
"fingerprint": "1961351c7f028d02202f915a6d36c658"
},
{
"severity": "major",
"location": {
"path": "dummy_file_name.h",
"positions": {
"begin": {
"line": "7",
"column": "7"
}
}
},
"description": "12345 Run-time Check: Overflow",
"fingerprint": "fb6455c4794157cb304be4106e115e35"
},
{
"severity": "critical",
"location": {
Expand Down
8 changes: 4 additions & 4 deletions tests/test_polyspace.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def test_code_prover_tsv_file(self):
stdout_log
)
self.assertEqual(count, count_sum)
self.assertEqual(count, 24)
self.assertEqual(count, 19)


class TestBugFinderWarnings(unittest.TestCase):
Expand Down Expand Up @@ -79,7 +79,7 @@ def test_config_file(self):
'--config', str(TEST_IN_DIR / 'config_example_polyspace.yml'),
str(TEST_IN_DIR / 'polyspace.tsv')
])
self.assertEqual(66, retval)
self.assertEqual(61, retval)

def test_code_quality(self):
filename = 'polyspace_code_quality.json'
Expand All @@ -90,7 +90,7 @@ def test_code_quality(self):
'--config', str(TEST_IN_DIR / 'config_example_polyspace.yml'),
str(TEST_IN_DIR / 'polyspace.tsv'),
])
self.assertEqual(66, retval)
self.assertEqual(61, retval)
self.assertTrue(filecmp.cmp(out_file, ref_file))

def test_code_quality_no_green(self):
Expand All @@ -101,7 +101,7 @@ def test_code_quality_no_green(self):
'--config', str(TEST_IN_DIR / 'config_example_polyspace_green.yml'),
str(TEST_IN_DIR / 'polyspace.tsv'),
])
self.assertEqual(66, retval)
self.assertEqual(61, retval)
self.assertTrue(filecmp.cmp(out_file, ref_file))

def test_exclude_yaml_config(self):
Expand Down

0 comments on commit 10b1b16

Please sign in to comment.